-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to FFMPEG_jll 4.3.1 with optional nvidia hardware accelerated encoding #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
===========================================
+ Coverage 97.43% 100.00% +2.56%
===========================================
Files 1 1
Lines 39 38 -1
===========================================
Hits 38 38
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
ffmpeg 4.3.1 with optional nvidia hardware acceleration enabled
976fbea
to
92ae393
Compare
Tests are passing here. FreeBSD appears to be an unrelated CI julia issue (any idea @ararslan ?) I've tested downstream VideoIO on a MacOS non-gpu, and ubuntu gpu system, and tests pass. I believe this should be a bump to 0.4.0 given it upgrades ffmpeg from 4.1 to 4.3 @SimonDanisch what do you think? I want to be careful about messing up downstream plotting packages, which I already did twice today already.. |
The minor version bump should protect downstream packages here, so I'll merge and release |
Ah yeah, we should switch the FreeBSD CI here from Cirrus to Travis. Cirrus FreeBSD images inexplicably stopped working a while ago, luckily just in time for Travis to add support for it. |
Waiting on JuliaPackaging/Yggdrasil#1384Will need re-running once that releases